gh-128661: Fix typing.evaluate_forward_ref not showing deprecation
#128663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexWaygood
changed the title
typing.evaluate_forward_ref not showing deprecataiontyping.evaluate_forward_ref not showing deprecation
AlexWaygood
approved these changes
Jan 9, 2025
|
I don't think we should have done this; it makes the interface excessively clunky. |
|
@JelleZijlstra what's your opinion about the alternative? |
|
The code was correct as is. Forcing people to write |
|
Hm, looks like other similar APIs also has this pattern. Like I got confused by Lines 1053 to 1055 in 1b39b50 _sentinel there, if it is not a default?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now calling
typing.evaluate_forward_refwithouttype_paramsraises a warning, as it should.Calling
ForwardRef._evaluateonly raises 1 warning, as it should.I've also covered all branches. After:
No backports are needed, this is 3.14 only feature.
typing.evaluate_forward_refis not fully covered #128661